O3-1157: Added field to search and select patient identifiers from implementer tools #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File size impactMerging O3-1157-configurable-identifiers into master impact files as follow: @openmrs/esm-devtools-app (+0.04%)
@openmrs/esm-implementer-tools-app (+0.48%)
@openmrs/esm-login-app (+0.01%)
@openmrs/esm-offline-tools-app (+0.01%)
@openmrs/esm-primary-navigation-app (+0.01%)
@openmrs/esm-app-shell (+0.01%)
|
File size impactMerging O3-1157-configurable-identifiers into master impact files as follow: @openmrs/esm-devtools-app (+0.04%)
@openmrs/esm-implementer-tools-app (+0.48%)
@openmrs/esm-login-app (+0.01%)
@openmrs/esm-offline-tools-app (+0.01%)
@openmrs/esm-primary-navigation-app (+0.01%)
@openmrs/esm-app-shell (+0.01%)
|
ZacButko
approved these changes
Apr 5, 2022
|
|
||
| const filteredResults: Array<PatientIdentifierType> | undefined = | ||
| useMemo(() => { | ||
| if (!isLoading && searchTerm && searchTerm !== "") { |
There was a problem hiding this comment.
"" is considered false, so searchTerm and searchTerm !== "" is redundant
There was a problem hiding this comment.
Oh yes, thanks, I'll just update it.
| @@ -0,0 +1,107 @@ | |||
| import React, { useState, useMemo } from "react"; | |||
| import uniqueId from "lodash-es/uniqueId"; | |||
There was a problem hiding this comment.
Is this the UUID library that we use site-wide?
There was a problem hiding this comment.
No, this is just for generating a unique id for the Input field.
The site-wide application is UUID version 4, afaik.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
I have added a search field for searching and selecting a patient-identifier-type's UUID, similar to searching a concept UUID/ person-attribute-type UUID. Along with that, I've added the UUID validator for the field.
Screenshots
Related Issue
https://issues.openmrs.org/browse/O3-1157
Other